AIX - 47/100
Basics - 12/12
- readme.txt file included with submission - 6/6
- Unpack and compile correctly - 6/6
Backgrounding - 8/20
When I try
/c/null.exe &
I cannot type additional commands in the shell. You correctly pass info to Spawn but don't use it when you start_user_thread. Also need other mods. I fixed this so I could go on and evaluate your other changes to the code.
Killing - 15/40
I can't get by the failed assertion error.
PS - 12/20
Names don't exist. Status incorrect.
Above and Beyond - 0/8
I would recommend fixing some of these errors and resubmitting.
AmigaDOS - 89/100
Basics - 12/12
- readme.txt file included with submission - 6/6
- Unpack and compile correctly - 6/6
Backgrounding - 20/20
Killing - 33/40
I create a foreground process without the parent calling wait. Killing this process should create a zombie. Your code does not. When I try to kill a zombie I get a failed assertion error. Otherwise this looks good.
PS - 20/20
Good. ps does list zombie processes
Above and Beyond - 4/8
BeOS - 87/100
Basics - 12/12
- readme.txt file included with submission - 6/6
- Unpack and compile correctly - 6/6
Backgrounding - 20/20
This looks good
Killing - 34/40
- can't seem to kill sleeping processes
- I create a foreground process without the parent calling wait. Killing this process should create a zombie. Your code does not.
PS - 18/20
- names not displayed
- zombie displayed -> looks good
Above and Beyond - 3/8
Chipewa - 91/100
Basics - 12/12
- readme.txt file included with submission - 6/6
- Unpack and compile correctly - 6/6
Backgrounding - 17/20
- when I background newshell I get an infinite loop of Background processes and their children cannot receive input.
- Other than that it looks good
Killing - 36/40
- Killing of foreground process with parent that didn't call wait creates zombie as expected
- You allow killing of zombies -4
PS - 20/20
- Displays zombie processes fine
Above and Beyond - 6/8
Extremely complete solution (re. number of queues examined, for example)
Croquet - 95/100
Basics - 12/12
- readme.txt file included with submission - 6/6
- Unpack and compile correctly - 6/6
Backgrounding - 20/20
Killing - 40/40
- contrary to specs you allow killing of zombies.
- killing foreground process with parent that doesn't wait correctly results in a zombie
- looks good!
PS - 20/20
- display zombies correctly
Above and Beyond - 3/8
- It would be nice if you displayed some messages. For example, when you kill a background process due to it calling readline you could at list print a line stating it was killed.
EOS - 70/100
Basics - 12/12
Backgrounding - 16/20
- getkey does not return -1 for background process
Killing - 20/40
- as you know, kill doesn't work
- your kill fn should be similar to Exit in kthread.
PS - 20/20
- looks good
Above and Beyond - 2/8
geOS- 66/100
Basics - 12/12
Backgrounding - 18/20
- exiting when a background process tries to get input would be good
Killing - 10/40
Ok. As you know this doesn't work. You need to mirror your code more on that of exit.
PS - 20/20
- Looks good & good handling of zombies
Above and Beyond - 2/8
Longhorn - 93/100
Basics - 12/12
Backgrounding - 20/20
Killing - 36/40
- shouldn't be able to kill a zombie
- Other than that this looks good
PS - 20/20
Above and Beyond - 5/8
Minux - 95/100
Basics - 12/12
Backgrounding - 16/20
- newshell & results in infinite printing of '$'
Killing - 40/40
- Extremely good handling of zombies
PS - 20/20
Nice handling of zombies!
$ ps PID PPID PRIO STAT COMMAND 1 0 5 S [kernel] 2 0 0 R [kernel] 3 0 5 S [kernel] 4 0 5 S [kernel] 5 0 5 S [kernel] 6 1 1 S /c/shell.exe 8 7 1 Z /c/long.exe 11 10 1 Z /c/null.exe 14 6 1 R /c/ps.exe
Above and Beyond - 7/8
Oberon - 63/100
Basics - 12/12
Backgrounding - 16/20
- getkey should return -1.
- Other than that it looks great
Killing - 15/40
- Infinite loop in sys_kill
PS - 17/20
- process name does not appear
Above and Beyond - 3/8
Plan_9 - 92/100
Basics - 12/12
Backgrounding - /20
Killing - 36/40
- killing of foreground process with parent that doesn't wait does not work. the kill hangs.
- Other than that it works great!
PS - 20/20
- good - including display of zombies
Above and Beyond - 4/8
Symbian - 88/100
Basics - 12/12
Backgrounding - 17/20
- newshell & results in infinite loop
$ Background process! Unable to process input.
Killing - 34/40
- you should prevent killing of zombies
- killing a foreground process with a parent that doesn't wait should create a zombie, not completely kill the process.
PS - 20/20
- Great! including displaying zombies
Above and Beyond - 5/8